chore: simplify routing logic [Part 2]: navigate.tsx

[MounirDhahri]

Description

This PR brings some simplifications to navigate.

The goal here is simple

• Make it smaller
• Raise errors in case navigation is not ready (this will help us tell if we are navigating before navigation is ready)

What comes next?
We have two props that do the same thing now: replaceActiveModal and replaceActiveScreen. We can replace both with a simple one.

For reviewers:
I suggest you hide white spaces - start here

PR Checklist

• I have tested my changes on iOS and Android.
• I hid my changes behind a feature flag, or they don't need one.
• I have included screenshots or videos, or I have not changed the UI.
• I have added tests, or my changes don't require any.
• I added an app state migration, or my changes do not require one.
• I have documented any follow-up work that this PR will require, or it does not require any.
• I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

• I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

• simplify routing logic [Part 2]: navigate.tsx

Need help with something? Have a look at our docs, or get in touch with us.

[MounirDhahri]

Fixing tests

[olerichter00]

Looks good 🌟

[ArtsyOpenSource]

This PR contains the following changes:

• Dev changes (simplify routing logic [Part 2]: navigate.tsx - MounirDhahri)

Generated by 🚫 dangerJS against 5d1787e