fix(ONYX-1516): fix null in auction result screen header, and spacing on the auctions screen #11510
+16
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariakoko
changed the title
…-on-the-auction-result-header-sales-screen-layout-is-incorrect
olerichter00
previously approved these changes
Feb 11, 2025
| @@ -54,9 +54,13 @@ export const AuctionResult: React.FC<Props> = (props) => { | |||
|
|
|||
| const tracking = useTracking() | |||
|
|
|||
| const headerTitleString = auctionResult.dateText | |||
There was a problem hiding this comment.
very minor: IMO, there is no need to add the variable type to the variable name.
Suggested change
| const headerTitleString = auctionResult.dateText | |
| const headerTitle = auctionResult.dateText |
Comment on lines
53
to
56
| onPress={() => { | ||
| trackEvent(tracks.tappedHeader(contextScreenOwnerType)) | ||
| navigate("/auctions/lots-for-you-ending-soon") | ||
| }} |
There was a problem hiding this comment.
To enable prefetching 🚀
Suggested change
| onPress={() => { | |
| trackEvent(tracks.tappedHeader(contextScreenOwnerType)) | |
| navigate("/auctions/lots-for-you-ending-soon") | |
| }} | |
| href="/auctions/lots-for-you-ending-soon" | |
| onPress={() => { | |
| trackEvent(tracks.tappedHeader(contextScreenOwnerType)) | |
| }} |
MounirDhahri
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves ONYX-1516
Description
Fix:
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.