Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update infinite discovery app entry point #11530

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Conversation

MounirDhahri
Copy link
Member

@MounirDhahri MounirDhahri commented Feb 11, 2025

This PR resolves DIA-1126

Description

This PR updates the app entry point to infinite discovery.

Blocked by: artsy/metaphysics#6425

Note: the image will be handled separately later.

Example

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • update app entry point - mounir

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@MounirDhahri MounirDhahri self-assigned this Feb 11, 2025
@MounirDhahri MounirDhahri force-pushed the feat/update-entry-point branch from 4dac8dd to 9dcffc4 Compare February 12, 2025 11:02
@MounirDhahri MounirDhahri marked this pull request as ready for review February 12, 2025 11:03
@ArtsyOpenSource
Copy link
Contributor

This PR contains the following changes:

  • Cross-platform user-facing changes (update app entry point - mounir - MounirDhahri)

Generated by 🚫 dangerJS against 9dcffc4

Copy link
Contributor

@araujobarret araujobarret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

image

Only have one question, the position of the text and the button is different, so we still need to do more changes to finish that ticket. Is there a plan?

@@ -141,6 +161,7 @@ const HomeViewSectionCardFragment = graphql`
title
subtitle
href
badgeText
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, didn't know we already had more visual props from this element in MP!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saw the MP PR 😂

@iskounen iskounen merged commit f32e41f into main Feb 12, 2025
8 checks passed
@iskounen iskounen deleted the feat/update-entry-point branch February 12, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants