Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor make offer button #11540

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MounirDhahri
Copy link
Member

This PR resolves []

Description

This PR refactors the make offer button to remove an old issue affecting DX

Before After
Simulator Screenshot - iPhone 16 Pro - 2025-02-12 at 12 12 23 Simulator Screenshot - iPhone 16 Pro - 2025-02-12 at 12 19 23
Before

After

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

  • refactor make offer button - mounir

Need help with something? Have a look at our docs, or get in touch with us.

@MounirDhahri MounirDhahri self-assigned this Feb 12, 2025
@ArtsyOpenSource
Copy link
Contributor

This PR contains the following changes:

  • Dev changes (refactor make offer button - mounir - MounirDhahri)

Generated by 🚫 dangerJS against f61eeb1

Copy link
Member

@gkartalis gkartalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! We def need to start addressing those more actively

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants