Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove modular headers hack #11550

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

brainbicycle
Copy link
Contributor

@brainbicycle brainbicycle commented Feb 12, 2025

This PR resolves PHIRE-1415

Description

Removes the modular headers hack we had in place for firebase compatibility with flipper:

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

  • remove modular headers hack and use recommended firebase settings - brian

Need help with something? Have a look at our docs, or get in touch with us.

@brainbicycle brainbicycle self-assigned this Feb 12, 2025
@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Feb 12, 2025

This PR contains the following changes:

  • Dev changes (remove modular headers hack and use recommended firebase settings - brian - brainbicycle)

Generated by 🚫 dangerJS against 052862d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants