-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: sentry alert severity levels #9623
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
559a186
to
326afcf
Compare
MrSltun
previously approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work George!! 🔥 🌟 🚀
MounirDhahri
reviewed
Dec 6, 2023
src/app/Scenes/MyCollection/Screens/ArtworkForm/Screens/MyCollectionArtworkFormMain.tsx
Show resolved
Hide resolved
araujobarret
previously approved these changes
Dec 6, 2023
8 tasks
gkartalis
commented
Dec 7, 2023
gkartalis
commented
Dec 7, 2023
MounirDhahri
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves PHIRE-484
Description
This PR adjusts the severity alerts of the sentry messages in some areas.
info
attachStacktrace
to init in order to have better stacktraces for every messagecaptureMessage
to immediately be able to locate the issuecaptureException
withcaptureMessage
since they are not stuff that we should worry too much aboutunable to load in tab
message to beerror
level cause these are the areas that we would like more visibility onBonus
What we expect from these changes
The color coding will change a bit on the
#practice-mobile-notifications
slack channel and we will be able to see with red only the important request issues (unable to load).We will still have the rest displayed with blue color like this event
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.