Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: sentry alert severity levels #9623

Merged
merged 9 commits into from
Dec 7, 2023
Merged

Conversation

gkartalis
Copy link
Member

@gkartalis gkartalis commented Dec 4, 2023

This PR resolves PHIRE-484

Description

This PR adjusts the severity alerts of the sentry messages in some areas.

  • The default severity is info
  • Adds attachStacktrace to init in order to have better stacktraces for every message
  • Adds helpful messages to some of the captureMessage to immediately be able to locate the issue
  • replaces some captureException with captureMessage since they are not stuff that we should worry too much about
  • Changes unable to load in tab message to be error level cause these are the areas that we would like more visibility on

Bonus

  • fixes some linting issues in one test

What we expect from these changes

The color coding will change a bit on the #practice-mobile-notifications slack channel and we will be able to see with red only the important request issues (unable to load).

We will still have the rest displayed with blue color like this event

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

  • adjust sentry alert severity levels - gkartalis

Need help with something? Have a look at our docs, or get in touch with us.

@gkartalis gkartalis self-assigned this Dec 4, 2023
@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Dec 4, 2023

This PR contains the following changes:

  • Dev changes (adjust sentry alert severity levels - gkartalis)

Generated by 🚫 dangerJS against dd6913c

@gkartalis gkartalis force-pushed the gkartalis/severity-sentry branch from 559a186 to 326afcf Compare December 6, 2023 09:33
@gkartalis gkartalis marked this pull request as ready for review December 6, 2023 11:31
MrSltun
MrSltun previously approved these changes Dec 6, 2023
Copy link
Member

@MrSltun MrSltun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work George!! 🔥 🌟 🚀

araujobarret
araujobarret previously approved these changes Dec 6, 2023
@gkartalis gkartalis dismissed stale reviews from araujobarret and MrSltun via d0581de December 7, 2023 13:06
@gkartalis gkartalis assigned brainbicycle and unassigned gkartalis Dec 7, 2023
Copy link
Member

@MounirDhahri MounirDhahri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brainbicycle brainbicycle merged commit 5261a4d into main Dec 7, 2023
@brainbicycle brainbicycle deleted the gkartalis/severity-sentry branch December 7, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants