-
Notifications
You must be signed in to change notification settings - Fork 1
queue pr fixes #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
queue pr fixes #241
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -44,6 +44,7 @@ import { createPrService } from "./services/prs/prService"; | |
| import { createPrPollingService } from "./services/prs/prPollingService"; | ||
| import { createQueueLandingService } from "./services/prs/queueLandingService"; | ||
| import { createIssueInventoryService } from "./services/prs/issueInventoryService"; | ||
| import { createPathToMergeOrchestrator } from "./services/prs/pathToMergeOrchestrator"; | ||
| import { createPrSummaryService } from "./services/prs/prSummaryService"; | ||
| import { | ||
| detectDefaultBaseRef, | ||
|
|
@@ -2380,6 +2381,27 @@ app.whenReady().then(async () => { | |
| // Wire agentChatService into prService for integration resolution | ||
| prService.setAgentChatService(agentChatService); | ||
|
|
||
| const pathToMergeOrchestrator = createPathToMergeOrchestrator({ | ||
| logger, | ||
| prService, | ||
| laneService, | ||
| agentChatService, | ||
| sessionService, | ||
| issueInventoryService, | ||
| conflictService, | ||
| defaultModelId: null, | ||
| defaultReasoningEffort: null, | ||
| }); | ||
| setImmediate(() => { | ||
| try { | ||
| pathToMergeOrchestrator.resumeFromPersistedState(); | ||
| } catch (err) { | ||
| logger.warn("path_to_merge.resume_failed", { | ||
| error: err instanceof Error ? err.message : String(err), | ||
| }); | ||
| } | ||
| }); | ||
|
Comment on lines
+2384
to
+2403
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Dispose the path-to-merge orchestrator during context teardown. The orchestrator is now resumed from persisted state, but it is not disposed in Proposed fix--- a/apps/desktop/src/main/main.ts
+++ b/apps/desktop/src/main/main.ts
@@
try {
+ ctx.pathToMergeOrchestrator?.dispose?.();
+ } catch {
+ // ignore
+ }
+ try {
ctx.prPollingService.dispose();
} catch {
// ignore
}🤖 Prompt for AI Agents |
||
|
|
||
| const gitService = createGitOperationsService({ | ||
| laneService, | ||
| operationService, | ||
|
|
@@ -2793,6 +2815,7 @@ app.whenReady().then(async () => { | |
| conflictService, | ||
| prService, | ||
| issueInventoryService, | ||
| pathToMergeOrchestrator, | ||
| queueLandingService, | ||
| sessionService, | ||
| ptyService, | ||
|
|
@@ -3629,6 +3652,7 @@ app.whenReady().then(async () => { | |
| appControlService, | ||
| queueLandingService, | ||
| issueInventoryService, | ||
| pathToMergeOrchestrator, | ||
| prSummaryService, | ||
| reviewService, | ||
| jobEngine, | ||
|
|
@@ -3739,6 +3763,7 @@ app.whenReady().then(async () => { | |
| prPollingService: null, | ||
| queueLandingService: null, | ||
| issueInventoryService: null, | ||
| pathToMergeOrchestrator: null, | ||
| prSummaryService: null, | ||
| reviewService: null, | ||
| jobEngine: null, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't persist pipeline overrides during
preview.This now runs
issue_inventory.savePipelineSettingsforade prs path-to-merge preview ...too, so a prompt preview mutates the PR's saved pipeline configuration. That makes a read-only preview stateful and can silently affect later real runs.Suggested fix
📝 Committable suggestion