Skip to content

Optimize chat and mission summary scans #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arul28 merged 1 commit into from
May 17, 2026
Merged

Optimize chat and mission summary scans #316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions apps/desktop/src/main/services/orchestrator/aiOrchestratorService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2682,13 +2682,29 @@ Check all worker statuses and continue managing the mission from here. Read work

const buildMissionStateProgressFromGraph = (graph: OrchestratorRunGraph): MissionStateProgress => {
const relevantSteps = filterExecutionSteps(graph.steps);
let completedSteps = 0;
const activeWorkers: string[] = [];
const blockedSteps: string[] = [];
const failedSteps: string[] = [];
for (const step of relevantSteps) {
if (MISSION_STATE_TERMINAL_STEP_STATUSES.has(step.status)) {
completedSteps += 1;
}
if (step.status === "running") {
activeWorkers.push(step.stepKey);
} else if (step.status === "blocked") {
blockedSteps.push(step.stepKey);
} else if (step.status === "failed") {
failedSteps.push(step.stepKey);
}
}
return {
currentPhase: currentPhaseFromGraph(graph),
completedSteps: relevantSteps.filter((step) => MISSION_STATE_TERMINAL_STEP_STATUSES.has(step.status)).length,
completedSteps,
totalSteps: relevantSteps.length,
activeWorkers: relevantSteps.filter((step) => step.status === "running").map((step) => step.stepKey),
blockedSteps: relevantSteps.filter((step) => step.status === "blocked").map((step) => step.stepKey),
failedSteps: relevantSteps.filter((step) => step.status === "failed").map((step) => step.stepKey),
activeWorkers,
blockedSteps,
failedSteps,
};
};

Expand Down
23 changes: 19 additions & 4 deletions apps/desktop/src/main/services/orchestrator/coordinatorTools.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,14 +391,29 @@ function resolveCurrentPhase(graph: OrchestratorRunGraph): string {

function buildMissionStateProgress(graph: OrchestratorRunGraph): MissionStateProgress {
const relevantSteps = filterExecutionSteps(graph.steps);
const completedSteps = relevantSteps.filter((step) => TERMINAL_STEP_STATUSES.has(step.status)).length;
let completedSteps = 0;
const activeWorkers: string[] = [];
const blockedSteps: string[] = [];
const failedSteps: string[] = [];
for (const step of relevantSteps) {
if (TERMINAL_STEP_STATUSES.has(step.status)) {
completedSteps += 1;
}
if (step.status === "running") {
activeWorkers.push(step.stepKey);
} else if (step.status === "blocked") {
blockedSteps.push(step.stepKey);
} else if (step.status === "failed") {
failedSteps.push(step.stepKey);
}
}
return {
currentPhase: resolveCurrentPhase(graph),
completedSteps,
totalSteps: relevantSteps.length,
activeWorkers: relevantSteps.filter((step) => step.status === "running").map((step) => step.stepKey),
blockedSteps: relevantSteps.filter((step) => step.status === "blocked").map((step) => step.stepKey),
failedSteps: relevantSteps.filter((step) => step.status === "failed").map((step) => step.stepKey),
activeWorkers,
blockedSteps,
failedSteps,
};
}

Expand Down
48 changes: 38 additions & 10 deletions apps/desktop/src/main/services/orchestrator/orchestratorService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4125,12 +4125,26 @@ export function createOrchestratorService({

const runSteps = listStepRows(args.run.id).map(toStep);
const frontier = {
pending: runSteps.filter((step) => step.status === "pending").length,
ready: runSteps.filter((step) => step.status === "ready").length,
running: runSteps.filter((step) => step.status === "running").length,
blocked: runSteps.filter((step) => step.status === "blocked").length,
terminal: runSteps.filter((step) => TERMINAL_STEP_STATUSES.has(step.status)).length
pending: 0,
ready: 0,
running: 0,
blocked: 0,
terminal: 0
};
for (const step of runSteps) {
if (TERMINAL_STEP_STATUSES.has(step.status)) {
frontier.terminal += 1;
}
if (step.status === "pending") {
frontier.pending += 1;
} else if (step.status === "ready") {
frontier.ready += 1;
} else if (step.status === "running") {
frontier.running += 1;
} else if (step.status === "blocked") {
frontier.blocked += 1;
}
}
const openQuestions = Number(
db.get<{ count: number }>(
`
Expand Down Expand Up @@ -11350,15 +11364,21 @@ export function createOrchestratorService({
checkFanOutCompletion(args: { runId: string; completedStepKey: string }): boolean {
const { runId, completedStepKey } = args;
const allSteps = listStepRows(runId).map(toStep);
const completedStep = allSteps.find((s) => s.stepKey === completedStepKey);
const stepByKey = new Map<string, OrchestratorStep>();
for (const step of allSteps) {
if (!stepByKey.has(step.stepKey)) {
stepByKey.set(step.stepKey, step);
}
}
Comment on lines +11367 to +11372

@greptile-apps greptile-apps Bot May 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Adding a brief comment here would make the first-match intent explicit and prevent a well-meaning refactor from accidentally switching to last-match semantics.

Suggested change
const stepByKey = new Map<string, OrchestratorStep>();
for (const step of allSteps) {
if (!stepByKey.has(step.stepKey)) {
stepByKey.set(step.stepKey, step);
}
}
// Build index keyed by stepKey; keep the first occurrence to match prior Array.find semantics.
const stepByKey = new Map<string, OrchestratorStep>();
for (const step of allSteps) {
if (!stepByKey.has(step.stepKey)) {
stepByKey.set(step.stepKey, step);
}
}
Prompt To Fix With AI 
This is a comment left during a code review.
Path: apps/desktop/src/main/services/orchestrator/orchestratorService.ts
Line: 11367-11372

Comment:
Adding a brief comment here would make the first-match intent explicit and prevent a well-meaning refactor from accidentally switching to last-match semantics.

```suggestion
      // Build index keyed by stepKey; keep the first occurrence to match prior Array.find semantics.
      const stepByKey = new Map<string, OrchestratorStep>();
      for (const step of allSteps) {
        if (!stepByKey.has(step.stepKey)) {
          stepByKey.set(step.stepKey, step);
        }
      }
```

How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Fix in Claude Code

const completedStep = stepByKey.get(completedStepKey);
if (!completedStep) return false;

// Find the parent via fanOutParent in metadata
const meta = (completedStep.metadata ?? {}) as Record<string, unknown>;
const parentStepKey = meta.fanOutParent as string | undefined;
if (!parentStepKey) return false;

const parentStep = allSteps.find((s) => s.stepKey === parentStepKey);
const parentStep = stepByKey.get(parentStepKey);
if (!parentStep) return false;

const parentMeta = (parentStep.metadata ?? {}) as Record<string, unknown>;
Expand All @@ -11368,15 +11388,23 @@ export function createOrchestratorService({
// Check if all children are in a terminal state
const terminalStatuses = new Set<string>(["succeeded", "failed", "skipped", "superseded", "canceled"]);
const allDone = childKeys.every((key) => {
const child = allSteps.find((s) => s.stepKey === key);
const child = stepByKey.get(key);
return child && terminalStatuses.has(child.status);
});

if (allDone && parentMeta.fanOutComplete !== true) {
const updatedMeta = { ...parentMeta, fanOutComplete: true };
const now = nowIso();
const succeededCount = childKeys.filter((key) => allSteps.find((s) => s.stepKey === key)?.status === "succeeded").length;
const failedCount = childKeys.filter((key) => allSteps.find((s) => s.stepKey === key)?.status === "failed").length;
let succeededCount = 0;
let failedCount = 0;
for (const key of childKeys) {
const child = stepByKey.get(key);
if (child?.status === "succeeded") {
succeededCount += 1;
} else if (child?.status === "failed") {
failedCount += 1;
}
}

// VAL-STATE-002: Update parent step status to reflect variant outcomes.
// If any child succeeded → parent succeeded; if all failed → parent failed.
Expand Down
100 changes: 34 additions & 66 deletions apps/desktop/src/renderer/components/chat/AgentChatMessageList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ import type {
import { getModelById, resolveModelDescriptor, type ModelDescriptor } from "../../../shared/modelRegistry";
import { cn } from "../ui/cn";
import { formatTime } from "../../lib/format";
import { openExternalUrl, openUrlInAdeBrowser } from "../../lib/openExternal";
import { openUrlInAdeBrowser } from "../../lib/openExternal";
import { isPathEqualOrDescendant, isWindowsAbsolutePath, normalizePath } from "../../lib/pathUtils";
import { describeToolIdentifier, replaceInternalToolNames } from "./toolPresentation";
import { chatChipToneClass } from "./chatSurfaceTheme";
Expand Down Expand Up @@ -554,13 +554,6 @@ function StatusIcon({ status }: { status: "running" | "completed" | "failed" | "
return <ChatStatusGlyph status="working" size={13} />;
}

function PlanStepIcon({ status }: { status: string }) {
if (status === "completed") return <Checks size={13} weight="bold" className="text-emerald-400" />;
if (status === "failed") return <XCircle size={13} weight="bold" className="text-red-400" />;
if (status === "in_progress") return <Circle size={11} weight="fill" className="text-sky-400/80" />;
return <Circle size={11} weight="regular" className="text-muted-fg/40" />;
}

function todoItemStatusClass(status: string): string {
switch (status) {
case "completed":
Expand Down Expand Up @@ -3176,26 +3169,11 @@ function renderEvent(
);
}

type TurnSummaryTask = {
id: string;
description: string;
status: string;
};

type TurnSummaryFile = {
path: string;
kind: Extract<AgentChatEvent, { type: "file_change" }>["kind"];
status?: Extract<AgentChatEvent, { type: "file_change" }>["status"];
additions: number;
deletions: number;
};

type TurnSummary = {
turnId: string;
tasks: TurnSummaryTask[];
files: TurnSummaryFile[];
totalAdditions: number;
totalDeletions: number;
taskCount: number;
completedTaskCount: number;
changedFileCount: number;
backgroundAgentCount: number;
activeBackgroundAgentCount: number;
turnModel: { label: string; modelId?: string; model?: string } | null;
Expand All @@ -3207,18 +3185,19 @@ function deriveTurnSummary(
events: AgentChatEventEnvelope[],
turnModelState: DerivedTurnModelState | null,
): TurnSummary | null {
const latestTurnId = [...events]
.reverse()
.map((envelope) => getEventTurnId(envelope.event))
.find((turnId): turnId is string => Boolean(turnId));
let latestTurnId: string | null = null;
for (let i = events.length - 1; i >= 0; i -= 1) {
latestTurnId = getEventTurnId(events[i]!.event);
if (latestTurnId) break;
}
if (!latestTurnId) return null;

let latestTodoUpdate: Extract<AgentChatEvent, { type: "todo_update" }> | null = null;
let latestPlan: Extract<AgentChatEvent, { type: "plan" }> | null = null;
let turnStartedAt: number | null = null;
let turnEndedAt: number | null = null;
let ended = false;
const files = new Map<string, TurnSummaryFile>();
const changedFilePaths = new Set<string>();
const subagents = new Map<string, { background: boolean; status: ChatSubagentSnapshot["status"] }>();

for (const envelope of events) {
Expand All @@ -3245,14 +3224,7 @@ function deriveTurnSummary(
}

if (event.type === "file_change") {
const stats = summarizeDiffStats(event.diff);
files.set(event.path, {
path: event.path,
kind: event.kind,
status: event.status,
additions: stats.additions,
deletions: stats.deletions,
});
changedFilePaths.add(event.path);
continue;
}

Expand Down Expand Up @@ -3283,26 +3255,25 @@ function deriveTurnSummary(
}
}

const tasks: TurnSummaryTask[] = latestTodoUpdate
? latestTodoUpdate.items.map((item) => ({
id: item.id,
description: item.description,
status: item.status,
}))
: latestPlan
? latestPlan.steps.map((step, index) => ({
id: `plan-${index}`,
description: step.text,
status: step.status,
}))
: [];
const changedFiles = [...files.values()];
const totalAdditions = changedFiles.reduce((sum, file) => sum + file.additions, 0);
const totalDeletions = changedFiles.reduce((sum, file) => sum + file.deletions, 0);
const backgroundAgentCount = [...subagents.values()].filter((entry) => entry.background).length;
const activeBackgroundAgentCount = [...subagents.values()].filter((entry) => entry.background && entry.status === "running").length;
let taskCount = 0;
let completedTaskCount = 0;
const taskSource = latestTodoUpdate?.items ?? latestPlan?.steps ?? [];
for (const task of taskSource) {
taskCount += 1;
if (task.status === "completed") completedTaskCount += 1;
}
const changedFileCount = changedFilePaths.size;
let backgroundAgentCount = 0;
let activeBackgroundAgentCount = 0;
for (const entry of subagents.values()) {
if (!entry.background) continue;
backgroundAgentCount += 1;
if (entry.status === "running") {
activeBackgroundAgentCount += 1;
}
}

if (!tasks.length && !changedFiles.length && !backgroundAgentCount) {
if (!taskCount && !changedFileCount && !backgroundAgentCount) {
return null;
}

Expand All @@ -3313,12 +3284,11 @@ function deriveTurnSummary(

return {
turnId: latestTurnId,
tasks,
files: changedFiles,
taskCount,
completedTaskCount,
changedFileCount,
durationMs,
ended,
totalAdditions,
totalDeletions,
backgroundAgentCount,
activeBackgroundAgentCount,
turnModel: turnModelState?.map.get(latestTurnId) ?? null,
Expand All @@ -3336,9 +3306,7 @@ function formatTurnDuration(durationMs: number): string {

function TurnDivider({ summary }: { summary: TurnSummary }) {
if (!summary.ended) return null;
const completedCount = summary.tasks.filter((task) => task.status === "completed").length;
const totalCount = summary.tasks.length;
const taskLine = totalCount ? `${completedCount}/${totalCount} tasks complete` : null;
const taskLine = summary.taskCount ? `${summary.completedTaskCount}/${summary.taskCount} tasks complete` : null;
const agentLine = summary.backgroundAgentCount
? `${summary.backgroundAgentCount} background ${summary.backgroundAgentCount === 1 ? "agent" : "agents"}${
summary.activeBackgroundAgentCount > 0 ? ` · ${summary.activeBackgroundAgentCount} still running` : " finished"
Expand Down Expand Up @@ -3831,7 +3799,7 @@ export function AgentChatMessageList({
const turnSummary = useMemo(() => deriveTurnSummary(events, turnModelState), [events, turnModelState]);

const handleReviewChanges = useCallback(() => {
if (!turnSummary?.files.length) return;
if (!turnSummary?.changedFileCount) return;
const state = currentLaneId ? { laneId: currentLaneId } : undefined;
navigate("/files", state ? { state } : undefined);
}, [currentLaneId, navigate, turnSummary]);
Expand Down
Loading