Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for automatic naming of dimensions #29

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

OriolAbril
Copy link
Member

@OriolAbril OriolAbril commented Dec 5, 2024

Add tests to guarantee we don't inadvertently change the naming scheme.

Note the naming scheme and autonaming is different from current ArviZ
as the assumptions about sample dimensions have changed a bit
(hopefully to make it easier to use with data that isn't chain, draw, *shape).


📚 Documentation preview 📚: https://arviz-base--29.org.readthedocs.build/en/29/

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.57%. Comparing base (723044c) to head (0793ebe).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
+ Coverage   59.40%   66.57%   +7.16%     
==========================================
  Files          14       14              
  Lines        1116     1116              
==========================================
+ Hits          663      743      +80     
+ Misses        453      373      -80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@amaloney amaloney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants