Library gardening #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3 +/- ##
===========================================
- Coverage 90.90% 60.91% -30.00%
===========================================
Files 14 14
Lines 1056 1054 -2
===========================================
- Hits 960 642 -318
- Misses 96 412 +316 ☔ View full report in Codecov by Sentry. |
aloctavodia
approved these changes
Jun 5, 2024
|
|
||
| .. py:data:: stats.ci_prob | ||
| :type: float | ||
| :value: 0.83 |
There was a problem hiding this comment.
When did we switch to 0.83 vs 0.94?
There was a problem hiding this comment.
opened an issue #4 to discuss all rcParams changes and updates
|
Merging for now, we could move rcparams related stuff from the api/index file to its own file at any point if it is too intrusive/distracts from the rest of the functions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits:
The most relevant changes are doc related ones. I have changed the theme from furo to
sphinx-book-theme because this 2nd one is built on top of the pydata-sphinx-theme and
therefore supports xarray html output out of the box for both themes (no need for custom css then).
I have also tried adding the rcParams to the docs manually so they can be referenced,
if we like that we can use that to document them instead of the
arviz.rctemplatefile.📚 Documentation preview 📚: https://arviz-base--3.org.readthedocs.build/en/3/