Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plot_converge_dist: Add grouped argument #182

Merged
merged 2 commits into from
Mar 18, 2025
Merged

plot_converge_dist: Add grouped argument #182

merged 2 commits into from
Mar 18, 2025

Conversation

aloctavodia
Copy link
Contributor

@aloctavodia aloctavodia commented Mar 17, 2025

All variables together

azp.plot_convergence_dist(data)

all_grouped

Only "za_county" and "a" variables

azp.plot_convergence_dist(data),  var_names=["za_county", "a"])

some_grouped

Only "za_county" and "a" variables, not together

azp.plot_convergence_dist(data),  var_names=["za_county", "a"], grouped=False)

some_separated

This will fail for kind="ecdf" but work for the rest. The reason is that "g" has a different shape than ("za_county" or "a"). This should be fixed in arviz-stats.

azp.plot_convergence_dist(data),  kind="hist", var_names=["za_county", "a", "g"], grouped=False)

some_separated_dim


📚 Documentation preview 📚: https://arviz-plots--182.org.readthedocs.build/en/182/

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 8 lines in your changes missing coverage. Please review.

Project coverage is 73.56%. Comparing base (76fa269) to head (b739acc).

Files with missing lines Patch % Lines
src/arviz_plots/plots/convergencedistplot.py 71.42% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #182      +/-   ##
==========================================
- Coverage   73.62%   73.56%   -0.07%     
==========================================
  Files          34       34              
  Lines        3939     3960      +21     
==========================================
+ Hits         2900     2913      +13     
- Misses       1039     1047       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@AlexAndorra AlexAndorra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition @aloctavodia ! Left two comments

@aloctavodia
Copy link
Contributor Author

Thanks @AlexAndorra. Fixed

@aloctavodia aloctavodia merged commit a2fe64e into main Mar 18, 2025
3 checks passed
@aloctavodia aloctavodia deleted the converge_group branch March 18, 2025 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants