-
Notifications
You must be signed in to change notification settings - Fork 25
feat(SetComp): Add support for set comprehensions and necessary tests #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hi @nagajaideep , there are a few git conflicts here. |
Thanks for the update! I’m working on the proposal reformatting as suggested. I’ll resolve the conflicts, rebase the branch, and mark it as Ready for Review soon. Will ping you once both are ready! |
…omphresion method
@nagajaideep could you rebase yoru branch on top of the upstream main please? |
I just merged this PR: #245 let me know if it clear now. sorry for the confusion. |
No issues ivan |
Pull Request description
This PR introduces support for set comprehensions in ASTx by adding a
SetComp
literal representation and its correspondingSetCompType
. It also enhances type inference for set comprehensions and includes necessary test cases.This PR aims to Solve #197
How to test these changes
Pull Request checklists
Note:
proposed in this PR, in both image and ASCII formats. For more
information, check this Google Colab notebook:
https://colab.research.google.com/drive/1xXwHmOMkJKFSmhRvn4WYfSAsdDzMnawf?usp=sharing
Test basic creation and properties of SetComprehension.


OLD:
NEW:
Test SetComprehension with multiple generators.

Test SetComprehension with a non-numeric element type.

This PR is a:
About this PR:
Author's checklist:
complexity.
Additional information
Reviewer's checklist
Copy and paste this template for your review's note: