Skip to content

Generatorexp support #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Conversation

Zehen-249
Copy link
Contributor

@Zehen-249 Zehen-249 commented Mar 15, 2025

Pull Request description

Solve #199

Pull Request checklists

Note:

This PR is a:

  • bug-fix
  • new feature
  • maintenance

About this PR:

  • it includes tests.
  • the tests are executed on CI.
  • the tests generate log file(s) (path).
  • pre-commit hooks were executed locally.
  • this PR requires a project documentation update.

Author's checklist:

  • I have reviewed the changes and it contains no misspelling.
  • The code is well commented, especially in the parts that contain more
    complexity.
  • New and old tests passed locally.

Additional information

TREE Representation

image

String representation

image

passes all test case
image

Reviewer's checklist

Copy and paste this template for your review's note:

## Reviewer's Checklist

- [ ] I managed to reproduce the problem locally from the `main` branch
- [x] I managed to test the new changes locally
- [x] I confirm that the issues mentioned were fixed/resolved .

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Zehen-249 Zehen-249 force-pushed the generatorexp-support branch from d3d25fa to 73580c9 Compare March 16, 2025 04:03
- Change ASRKind code for GeneratorExp
- Add support for `YieldFromExpr` (arxlang#206)
- Add support for `AsyncFor` (arxlang#211)
change ASRKind code for GeneratorExp

feat: Add support for `YieldFromExpr` (arxlang#206)

 feat: Add support for `AsyncFor` (arxlang#211)
@Zehen-249 Zehen-249 force-pushed the generatorexp-support branch from 73580c9 to 163d50f Compare March 16, 2025 07:12
@xmnlab
Copy link
Contributor

xmnlab commented Mar 18, 2025

@Zehen-249 , please rebase your branch on top of the upstream/main.
so I can approve the CI workflow to be executed.

Copy link

This pull request has been marked as stale because it has been
inactive for more than 5 days. Please update this pull request
or it will be automatically closed in 5 days.

@github-actions github-actions bot added the Stale label Mar 24, 2025
@xmnlab
Copy link
Contributor

xmnlab commented Mar 29, 2025

this pr is already stale for a week, so I am closing it now.
thanks @Zehen-249.
if you still want to work on that. I recommend you to start a new PR, because we made big changes in the core, so probably it would be easy to start from a new branch on top of the upstream main.

@xmnlab xmnlab closed this Mar 29, 2025
@Zehen-249
Copy link
Contributor Author

I saw the changes in the recent development and I think I will create a new PR that would be easier to go forward. Thank you @xmnlab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants