Add dict comprehension Support

[Zehen-249]

Pull Request description

Add DictComprehension class to support Dictionary comprehension

Solve #198

• Share updated images of the graph representation of the new ASTx node
  proposed in this PR, in both image and ASCII formats. For more
  information, check this Google Colab notebook:
  https://colab.research.google.com/drive/1xXwHmOMkJKFSmhRvn4WYfSAsdDzMnawf?usp=sharing

This PR is a:

• bug-fix
• new feature
• maintenance

About this PR:

• it includes tests.
• the tests are executed on CI.
• the tests generate log file(s) (path).
• pre-commit hooks were executed locally.
• this PR requires a project documentation update.

Author's checklist:

• I have reviewed the changes and it contains no misspelling.
• The code is well commented, especially in the parts that contain more
  complexity.
• New and old tests passed locally.

Additional information

screenshot that helps to show the changes proposed

Copy and paste this template for your review's note:

## Reviewer's Checklist

- [ ] I managed to reproduce the problem locally from the `main` branch
- [ ] I managed to test the new changes locally
- [ ] I confirm that the issues mentioned were fixed/resolved .

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[xmnlab]

hi @Zehen-249 ! thanks for working on that. ensure you are running the pre-commit locally, and ping me here when all the tests on ci pass, please.

[Zehen-249]

Hey Ivan

I am failing his check in the modifiers file I haven't change anything in Modifiers.py

[github-actions]

This pull request has been marked as stale because it has been
inactive for more than 5 days. Please update this pull request
or it will be automatically closed in 5 days.

[xmnlab]

@Zehen-249 , maybe the issue was just locally .. on ci it worked.

[xmnlab]

please remove these comments.

btw, if you install with poetry install, you shouldn't need any of these hacks

[Zehen-249]

okay sure I will do it. I actually did used poetry.

[xmnlab]

key and value probably should be Expr instead of Indentifier ... but maybe we need to discuss a bit other part of this class.

let's consider this example:

>>> ast.dump(ast.parse("{'y': x*x for x in my_list}"))
"Module(body=[Expr(value=DictComp(key=Constant(value='y'), value=BinOp(left=Name(id='x', ctx=Load()), op=Mult(), right=Name(id='x', ctx=Load())), generators=[comprehension(target=Name(id='x', ctx=Store()), iter=Name(id='my_list', ctx=Load()), ifs=[], is_async=0)]))], type_ignores=[])"

se it seems we will also need to add ifs and the comprehension class as well.

[Zehen-249]

Will work on it.

[Zehen-249]

I actually did considered Expr for these variables but during pre-commit checks I was failing some checks bcoz, Expr did not have value attribute. But my tests was doing fine coz I had initialized key value as identifiers in the object creation.

[Zehen-249]

This pull request has been marked as stale because it has been inactive for more than 5 days. Please update this pull request or it will be automatically closed in 5 days.

Could you pls remove this stale

[xmnlab]

@Zehen-249 , I just added support for the Comprehension class, please update your PR to use that: #225

[Zehen-249]

hey @xmnlab I have created a new PR for this issue. Should CLOSE this PR.