Skip to content

fix : removed alert call from DashboardTasks duration validation #1951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tmdeveloper007 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix : removed alert call from DashboardTasks duration validation #1951

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions frontend/src/components/Dashboard/DashboardTasks.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ export default function DashboardTasks({ tasks, updateTask }) {
const navigate = useNavigate();
const [durationModalTask, setDurationModalTask] = useState(null);
const [actualDuration, setActualDuration] = useState("");
const [durationError, setDurationError] = useState("");

const priorityOrder = {
High: 3,
Expand Down Expand Up @@ -57,7 +58,7 @@ export default function DashboardTasks({ tasks, updateTask }) {
const durationValue = Number(actualDuration);

if (Number.isNaN(durationValue) || durationValue <= 0) {
alert("Please enter a valid duration in minutes");
setDurationError("Please enter a valid duration in minutes");
return;
}

Expand All @@ -69,6 +70,7 @@ export default function DashboardTasks({ tasks, updateTask }) {

setDurationModalTask(null);
setActualDuration("");
setDurationError("");
} catch (error) {
console.error("Failed to update task:", error);
}
Expand Down Expand Up @@ -170,15 +172,22 @@ export default function DashboardTasks({ tasks, updateTask }) {
type="number"
min="1"
value={actualDuration}
onChange={(e) => setActualDuration(e.target.value)}
onChange={(e) => {
setActualDuration(e.target.value);
setDurationError("");
}}
className="w-full p-2 border border-soft rounded-lg text-black dark:placeholder-slate-500"
placeholder="Actual duration in minutes"
/>
{durationError && (
<p className="mt-1 text-sm text-red-500">{durationError}</p>
)}
<div className="flex justify-end gap-3 mt-5">
<button
onClick={() => {
setDurationModalTask(null);
setActualDuration("");
setDurationError("");
}}
className="px-4 py-2 rounded-lg border border-soft text-black hover:bg-gray-100 transition"
>
Expand Down