Skip to content

Add heart box design #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amychurchwell
Copy link

Hi there! This is a box design I created from some text art I found on https://cutekaomoji.com a few years back. I've been using it in my .zshrc file locally and thought it might be a worthy contribution.

# ┌────────────── ∘°∘♡∘°∘ ──────────────┐
#              File: .zshrc
#
#   Used for setting interactive shell 
#   configuration and executing commands
#   for all users, will be read when
#   starting as an interactive shell.
#
# └────────────── °∘∘♡∘∘° ──────────────┘

Unfortunately, I struggled building this project and have not been able to test the design. I'm on MacOS and tried to use homebrew to install the dependencies on https://boxes.thomasjensen.com/build.html#unix, but continue to run into make problems that I can't really make sense of 🧐 ...

| For compilation info please refer to the boxes compilation FAQ
| at https://boxes.thomasjensen.com/faq.html#q5
/Applications/Xcode.app/Contents/Developer/usr/bin/make -C src BOXES_PLATFORM=unix LEX=flex YACC=bison build
echo parser.o lex.yy.o cmdline.o discovery.o generate.o input.o list.o parsecode.o parsing.o query.o regulex.o remove.o shape.o tools.o unicode.o > ../out/modules.txt
/Applications/Xcode.app/Contents/Developer/usr/bin/make -C ../out -f ../src/Makefile BOXES_PLATFORM=unix ALL_OBJ="parser.o lex.yy.o boxes.o cmdline.o discovery.o generate.o input.o list.o parsecode.o parsing.o query.o regulex.o remove.o shape.o tools.o unicode.o" STRIP=true \
	    CFLAGS_ADDTL="-O " flags_unix boxes
echo parser.o lex.yy.o cmdline.o discovery.o generate.o input.o list.o parsecode.o parsing.o query.o regulex.o remove.o shape.o tools.o unicode.o > ../out/modules.txt
bison --warnings=all --verbose --defines=parser.h --output=parser.c ../src/parser.y
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/bison: unrecognized option `--warnings=all'
Try `/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/bison --help' for more information.
make[2]: *** [parser.c] Error 1
make[1]: *** [build] Error 2
make: *** [build] Error 2

So hopefully this design is coded correctly, apologies if not.

@tsjensen
Copy link
Member

Thank you for sharing this cute box design!

Unfortunately, since it's not ASCII, we can't use it at the moment, until #72 is implemented. But we'll keep it around so we can add it once MBCS designs are supported.

If you have trouble building boxes, consider opening a separate issue for that. Mac is one of the frequently used platforms, so it should be fairly straightforward to get a working copy of boxes on your Mac. (Then again, I don't have access to a Mac myself, but maybe we can get someone else to help you.)

@tsjensen tsjensen closed this Apr 22, 2022
@tsjensen tsjensen reopened this May 28, 2025
@tsjensen
Copy link
Member

Just found this again! Boxes supports UTF-8 config files in the meantime, so we can now adopt this box design, if you are still interested in contributing it.

Copy link
Member

@tsjensen tsjensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a number of comments with requests for small changes according to our design best practices. I really like it! 👍

sample
┌────────────── ∘°∘♡∘°∘ ──────────────┐


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some sample box content here, like in your PR description?

ends

shapes {
nw ("┌─")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make this narrower, without the horizontal line, which will be added by the NNW shape.

nnw ("─")
n (" ", "∘°∘♡∘°∘", " ")
nne ("─")
ne ("─┐")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make this narrower, without the horizontal line, which will be added by the NNE shape.

elastic (nnw,nne,ssw,sse)

padding {
vertical 3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
vertical 3
vertical 1

A little less padding seems right, wdyt?

revision "1.0"
revdate "April 19, 2022"
created "April 19, 2022"
tags "simple, box"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tags "simple, box"
tags ("unicode")

I think unicode is the only fitting tag in this case. Also, the tag syntax has slightly changed since last time. 🙂

tags "simple, box"

sample
┌────────────── ∘°∘♡∘°∘ ──────────────┐
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please indent the sample by exactly 4 spaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants