-
Notifications
You must be signed in to change notification settings - Fork 77
Add heart box design #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thank you for sharing this cute box design! Unfortunately, since it's not ASCII, we can't use it at the moment, until #72 is implemented. But we'll keep it around so we can add it once MBCS designs are supported. If you have trouble building boxes, consider opening a separate issue for that. Mac is one of the frequently used platforms, so it should be fairly straightforward to get a working copy of boxes on your Mac. (Then again, I don't have access to a Mac myself, but maybe we can get someone else to help you.) |
Just found this again! Boxes supports UTF-8 config files in the meantime, so we can now adopt this box design, if you are still interested in contributing it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a number of comments with requests for small changes according to our design best practices. I really like it! 👍
sample | ||
┌────────────── ∘°∘♡∘°∘ ──────────────┐ | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add some sample box content here, like in your PR description?
ends | ||
|
||
shapes { | ||
nw ("┌─") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make this narrower, without the horizontal line, which will be added by the NNW shape.
nnw ("─") | ||
n (" ", "∘°∘♡∘°∘", " ") | ||
nne ("─") | ||
ne ("─┐") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make this narrower, without the horizontal line, which will be added by the NNE shape.
elastic (nnw,nne,ssw,sse) | ||
|
||
padding { | ||
vertical 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vertical 3 | |
vertical 1 |
A little less padding seems right, wdyt?
revision "1.0" | ||
revdate "April 19, 2022" | ||
created "April 19, 2022" | ||
tags "simple, box" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tags "simple, box" | |
tags ("unicode") |
I think unicode
is the only fitting tag in this case. Also, the tag
syntax has slightly changed since last time. 🙂
tags "simple, box" | ||
|
||
sample | ||
┌────────────── ∘°∘♡∘°∘ ──────────────┐ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please indent the sample by exactly 4 spaces.
Hi there! This is a box design I created from some text art I found on https://cutekaomoji.com a few years back. I've been using it in my .zshrc file locally and thought it might be a worthy contribution.
Unfortunately, I struggled building this project and have not been able to test the design. I'm on MacOS and tried to use homebrew to install the dependencies on https://boxes.thomasjensen.com/build.html#unix, but continue to run into
make
problems that I can't really make sense of 🧐 ...So hopefully this design is coded correctly, apologies if not.