Skip to content

fix: broaden exception handling in MCPClient.close to avoid cancel-scope errors #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: broaden exception handling in MCPClient.close to avoid cancel-scope errors #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tinyagent/mcp_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,11 +109,11 @@ async def close(self):
if self.exit_stack:
try:
await self.exit_stack.aclose()
except (RuntimeError, asyncio.CancelledError) as e:
# Log the error but don't re-raise it
except Exception as e:
# Log any cleanup error (including cancel-scope mismatches) but don’t re-raise
self.logger.error(f"Error during client cleanup: {e}")
finally:
# Always reset these regardless of success or failure
# Reset client state unconditionally
self.session = None
self.exit_stack = AsyncExitStack()

Expand Down