Skip to content

fix: close the BES binary file fifo when receivers become unhealthy #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2025
Merged

fix: close the BES binary file fifo when receivers become unhealthy #275

merged 1 commit into from
Nov 21, 2025
+118 −21

Conversation

@gregmagolan
Copy link
Member

@gregmagolan gregmagolan commented Nov 20, 2025 •
edited
Loading

No description provided.

@gregmagolan gregmagolan force-pushed the close_fifo_on_bes_proxy_failures branch 2 times, most recently from bb4cb2a to 1630bcc Compare November 20, 2025 06:18
@aspect-workflows
Copy link

aspect-workflows bot commented Nov 20, 2025 •
edited
Loading

Test

12 test targets passed

Targets 
//integration_tests/aspect:configure_test [k8-fastbuild] 1m 46s
//integration_tests/aspect:flags_test [k8-fastbuild]     2m 4s
//integration_tests/aspect:help_test [k8-fastbuild]      1m 36s
//integration_tests/aspect:hints_test [k8-fastbuild]     1m 46s
//integration_tests/aspect:info_test [k8-fastbuild]      1m 28s
//integration_tests/aspect:init_test [k8-fastbuild]      47s
//integration_tests/aspect:lint_test [k8-fastbuild]      53s
//integration_tests/aspect:reenter_test [k8-fastbuild]   26s
//integration_tests/aspect:run_test [k8-fastbuild]       57s
//integration_tests/aspect:version_test [k8-fastbuild]   1m 31s
//pkg/plugin/system/bep:bep_test [k8-fastbuild]          92ms
//pkg/plugin/system:system_test [k8-fastbuild]           79ms

Total test execution time was 13m 16s. 91 tests (88.3%) were fully cached saving 9s.

Buildifier

@gregmagolan gregmagolan force-pushed the close_fifo_on_bes_proxy_failures branch 10 times, most recently from 28db665 to be04d90 Compare November 21, 2025 02:08
@gregmagolan gregmagolan marked this pull request as ready for review November 21, 2025 02:08
@gregmagolan gregmagolan force-pushed the close_fifo_on_bes_proxy_failures branch from be04d90 to dc3c332 Compare November 21, 2025 02:09
@gregmagolan gregmagolan force-pushed the close_fifo_on_bes_proxy_failures branch from dc3c332 to 067b114 Compare November 21, 2025 02:09
@gregmagolan gregmagolan merged commit ca8f9af into main Nov 21, 2025
3 checks passed
@gregmagolan gregmagolan deleted the close_fifo_on_bes_proxy_failures branch November 21, 2025 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gregmagolan