API_Rewrite: Only filter 'pre_http_request' when API rewriting is enabled
#306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
costdev
force-pushed
the
only_filter_pre_http_request_when_rewriting_is_enabled
branch
from
9b2c4d0 to
c180e11
Compare
afragen
approved these changes
Feb 21, 2025
costdev
deleted the
only_filter_pre_http_request_when_rewriting_is_enabled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What changed?
'pre_http_request'.API_Rewritetest to enable API rewriting.API_Rewritetest to check that the hook is not added when API rewriting is disabled.Why did it change?
The filter should only be applied when API rewriting is enabled.
This was causing errors on several screens when API rewriting was disabled.
Did you fix any specific issues?
Fixes #305
CERTIFICATION
By opening this pull request, I do agree to abide by the Code of Conduct and be bound by the terms of the Contribution Guidelines in effect on the date and time of my contribution as proven by the revision information in GitHub.