Admin_Settings: Various accessibility improvements #307
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What changed?
aria-describedby
to settings elements and a matchingid
attribute to the.description
element.label_for
argument toadd_settings_field()
calls to ensure the field labels are wrapped in the<label>
tags.Clear Log
andView Log
froma
elements tobutton
elements withtype="button"
so they don't trigger a form submit.Why did it change?
api_host_other
not having a label.Did you fix any specific issues?
Fixes #299
CERTIFICATION
By opening this pull request, I do agree to abide by the Code of Conduct and be bound by the terms of the Contribution Guidelines in effect on the date and time of my contribution as proven by the revision information in GitHub.