Dev/billhie/get browser link building #110
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillHiebert
commented
Jun 23, 2021
BillHiebert
commented
- Updated nuget pkg feeds
- Now targets netcoreapp3.1 and references the AspNetCore.App framework
- Replaced obsolete interfaces with updated ones
- Added StartupHook.cs and StartupHosting.cs to initialize browserlink
- Fixed some tests that were failing due to behavior change.
jodavis
suggested changes
Jun 24, 2021
|
|
||
| public Task CompleteAsync() | ||
| { | ||
| return _wrapped.CompleteAsync(); |
There was a problem hiding this comment.
It used to be possible for _wrapped to be null, if app.UseStaticFiles() wasn't included. We should check all references for null to be on the safe side, so we don't cause runtime errors in working applications.
| @@ -1,15 +1,16 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFrameworks>$(StandardTestTfms)</TargetFrameworks> | |||
| <!--<TargetFrameworks>$(StandardTestTfms)</TargetFrameworks>--> | |||
There was a problem hiding this comment.
nit: I would just remove this instead of commenting it out.
jodavis
approved these changes
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.