Skip to content
This repository was archived by the owner on Nov 6, 2018. It is now read-only.

Update Moq version - #281

Merged
pranavkm merged 2 commits into
devfrom
pranavkm-patch-1
Jun 21, 2017
Merged

Update Moq version#281
pranavkm merged 2 commits into
devfrom
pranavkm-patch-1

Conversation

@pranavkm

Copy link
Copy Markdown
Contributor

No description provided.

@natemcmaster

Copy link
Copy Markdown
Contributor

@natemcmaster natemcmaster left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@mikeharder

Copy link
Copy Markdown

CC: @ryanbrandenburg

Do we need to update this one repo before all the rest? See https://github.com/aspnet/Coherence-Signed/issues/583.

For the Moq version, 4.7.49 is the earliest version with the fixes we need, but 4.7.58 and 4.7.63 have been released since. Should we update to current latest 4.7.63? I assume we should use a consistent version across all our projects unless there's a reason to do otherwise.

@pranavkm

Copy link
Copy Markdown
Contributor Author

They've been releasing a build rather frequently of late: https://www.nuget.org/packages/Moq. Might be difficult for us to keep up with the latest.

@mikeharder

Copy link
Copy Markdown

Right now I would just use 4.7.49 since we know it fixes the NuGet warning and it has more downloads than the two newer releases.

Long-term I think we should have a plan for how to manage versions of all third-party dependencies. A few options:

  • Update only when needed
  • Update on a regular schedule (1/month, 1/quarter, etc)
  • Try to stay on latest version whenever it updates

@pranavkm

Copy link
Copy Markdown
Contributor Author

🆙 📅 to 4.7.49.

@pranavkm
pranavkm merged commit 56c7405 into dev Jun 21, 2017
@pranavkm
pranavkm deleted the pranavkm-patch-1 branch June 21, 2017 17:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants