Skip to content

Conversation

@assagman
Copy link
Owner

Summary

Addresses two valid review comments from PR #2:

  • Validate custom_version input — ensures strict semver format (X.Y.Z or v1.2.3), strips v prefix, and fails fast with clear error on invalid input
  • Remove head -10 truncation — changelog "Changed" section now includes all non-conventional commits instead of silently truncating

Changes

File Change
release-pr.yml Add semver validation for inputs.custom_version
release-pr.yml Remove head -10 from OTHERS changelog generation

Testing

  • Trigger release-pr workflow with invalid custom version (e.g., abc) — should fail
  • Trigger release-pr workflow with valid custom version (e.g., v2.0.0) — should succeed
  • Verify changelog includes all "Changed" entries on next release PR

Copilot AI review requested due to automatic review settings January 15, 2026 21:13
@gemini-code-assist
Copy link

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@assagman assagman merged commit 2944acc into main Jan 15, 2026
5 checks passed
@assagman assagman deleted the fix/gh-workflows branch January 15, 2026 21:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses two issues from a previous review: adds validation for the custom_version workflow input to ensure it follows strict semver format, and removes the head -10 truncation from the changelog generation to include all non-conventional commits.

Changes:

  • Add semver validation to custom_version input (strips v prefix, validates X.Y.Z format, fails with clear error on invalid input)
  • Remove head -10 truncation from OTHERS changelog generation to include all non-conventional commits

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions github-actions bot mentioned this pull request Jan 15, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant