Skip to content

Fix URLs to JavaDoc #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix URLs to JavaDoc #183

wants to merge 2 commits into from

Conversation

Madjosz
Copy link

@Madjosz Madjosz commented May 22, 2025

Latest JavaDoc pages include the module name in the URL.

This PR adds the module name to the URL path of :assertj-core-javadoc-root: and :assertj-guava-javadoc-root:.
Furthermore the following improvements are included:

  • link-attributes are now consistently used among AssertJ Core, AssertJ Guava, and AssertJ Joda Time
  • URLs including ... needed to be escaped
  • AssertJ DB was not touched for this PR

@Madjosz
Copy link
Author

Madjosz commented Aug 15, 2025

Hi @scordio
since you seem to be an active maintainer of this repo I would be delighted if you could take a look at this PR.
Kind regards

scordio
scordio requested changes Aug 15, 2025
View reviewed changes
Copy link
Member

@scordio scordio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Madjosz, thanks for the PR and the reminder, this totally slipped under my radar 🙂

@Madjosz Madjosz requested a review from scordio August 18, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scordio scordio Awaiting requested review from scordio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Madjosz @scordio