Fix column wrapping breaking with None values (fixes #312) #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It should probably use missingval value for consistency not an empty string. |
astanin
added
the
incomplete
I've updated the pull request |
|
@astanin any chance of this PR getting merged anytime soon? thanks! |
|
@astanin would love to see this merged! |
|
This problem nags me regularly. Could you give this pull request a new try? What is needed to get it merged? Edit: Ok, I've just seen #335, so it will maybe get into a new fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using wrapping (i.e. with
maxcolwidths) with a column that contains None values, the process crashes with the errorTypeError: NoneType takes no arguments.To solve that, an extra guard case is added, to return None as an empty string instead.
Includes a test.
Fixes #312