Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[formatter] do not emit warnings that the formatter conflicts with rule missing-trailing-comma if no conflicts #15807

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

XuehaiPan
Copy link
Contributor

@XuehaiPan XuehaiPan commented Jan 29, 2025

Summary

Only emit a warning if the formatter's setting skip-magic-trailing-comma is conflicting with the linter rule missing-trailing-comma (COM812).

The following settings can co-exist with each other.

[lint]
select = [
    "COM",  # flake8-commas
]

[formatter]
skip-magic-trailing-comma = false  # the default value

Test Plan

CI

…rule `missing-trailing-commas` if no conflicts
@XuehaiPan XuehaiPan force-pushed the do-not-warn-non-conflicting-rules branch from 95e0462 to 45b5fde Compare January 29, 2025 09:32
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@XuehaiPan XuehaiPan changed the title [formatter] do not emit warnings that the formatter conflicts with rule missing-trailing-commas if no conflicts [formatter] do not emit warnings that the formatter conflicts with rule missing-trailing-comma if no conflicts Jan 29, 2025
@dylwil3 dylwil3 added the formatter Related to the formatter label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
formatter Related to the formatter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants