Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flake8-comprehensions] Skip when TypeError present from too many (kw)args for C410,C411, and C418 #15838

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

dylwil3
Copy link
Collaborator

@dylwil3 dylwil3 commented Jan 30, 2025

Both list and dict expect only a single positional argument. Giving more positional arguments, or a keyword argument, is a TypeError and neither the lint rule nor its fix make sense in that context.

Closes #15810

@dylwil3 dylwil3 added bug Something isn't working rule Implementing or modifying a lint rule labels Jan 30, 2025
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@dylwil3 dylwil3 merged commit 071862a into astral-sh:main Jan 30, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working rule Implementing or modifying a lint rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

C410, C411, and C418 have false positives for calls with extra arguments
2 participants