Respect --project during uv python find (#11990)
#12049
Open
+231
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thejchap
changed the title
uv python find (#11990)
thejchap
force-pushed
the
bug/python-find-project
branch
12 times, most recently
from
eae8bb5 to
5c64c53
Compare
thejchap
changed the title
uv python find (#11990)uv python find (#11990)
thejchap
force-pushed
the
bug/python-find-project
branch
from
5c64c53 to
5f3da2d
Compare
## Summary this pr updates a couple discovery-related functions to accept a directory argument, used as the root directory when searching for a virtual environment ## Test Plan todo
thejchap
force-pushed
the
bug/python-find-project
branch
from
5f3da2d to
6490c09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #11990
uv python findto pass the--projectflag through to start the search for a python executable from that project, regardless of current directoryTest Plan
Before
$ cargo run python find --directory ~/src --project example /Users/justinchapman/.local/share/uv/python/cpython-3.13.0-macos-aarch64-none/bin/python3.13After
$ cargo run python find --directory ~/src --project example /Users/justinchapman/src/example/.venv/bin/python3