Error on lockfiles with inconsistent source distribution versions #12237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reject lockfiles where the package version and the wheel versions are incoherent. This implicitly checks that all wheel files have the same version. It does not check for the source dist version, since a source dist may not contain a version in the filename and attempting to deserialize source dist filenames we may not need is a performance overhead for something that's already slow in `uv run`. Fixes #12164
jtfmumm
reviewed
Mar 17, 2025
| @@ -264,7 +264,11 @@ impl<'a> Planner<'a> { | |||
| // Find the most-compatible wheel from the cache, since we don't know | |||
| // the filename in advance. | |||
| if let Some(wheel) = built_index.url(sdist)? { | |||
| if wheel.filename.name == sdist.name { | |||
| if wheel.filename.name == sdist.name | |||
There was a problem hiding this comment.
These will be false if we don't know the sdist version, right? Should we instead maintain the old behavior in that case?
Something like:
if wheel.filename.name == sdist.name
&& dist.version().map_or(true, |version| version == &wheel.filename.version)
zanieb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reject all cases where a source distribution builds into a wheel of a different version than was locked in the lockfile.
As an example:
This now fails with:
The potential clash could be with git dependencies that use a version-from-git integration. I.e., with the change, we're enforcing coherence where we've been previously lenient. It is on the other hand the only good option for catching errors such as #12164 for source distributions.
Needs tests.