Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uv build: add --keep-on-error #12292

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

da-x
Copy link

@da-x da-x commented Mar 18, 2025

While debugging build failures, it is sometimes useful to look at the build directory for logs. Let's allow not deleting it.

@zanieb
Copy link
Member

zanieb commented Mar 18, 2025

Should this just be the default behavior?

@zanieb zanieb requested a review from konstin March 18, 2025 17:57
@konstin konstin added the enhancement New feature or improvement to existing functionality label Mar 19, 2025
@konstin
Copy link
Member

konstin commented Mar 19, 2025

This is a neat idea! Assuming that the operating system reliably cleans up those directories on reboot, I'd actually prefer preserving temporary directories on build failure unconditionally.

@da-x
Copy link
Author

da-x commented Mar 19, 2025

I don't think we should change the default, as this applies to the ~/.cache/uv/build-v0 directory which the OS does not clean up.

@konstin
Copy link
Member

konstin commented Mar 19, 2025

Makes sense!

@zanieb
Copy link
Member

zanieb commented Mar 19, 2025

We could clean it with uv cache clean or uv cache prune though and we could overwrite it on a subsequent build so there's only a single build directory for a given project version. I'm sort of partial to retaining information on error unless there are major concerns about disk use?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants