Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for pre-releases to Python platform key regex #12380

Merged
merged 1 commit into from
Mar 23, 2025
Merged

Add support for pre-releases to Python platform key regex #12380

merged 1 commit into from
Mar 23, 2025

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Mar 21, 2025 •
edited
Loading

Needed for more test cases on top of #12374

@zanieb zanieb mentioned this pull request Mar 21, 2025
Merged
@zanieb zanieb marked this pull request as ready for review March 21, 2025 18:54
@zanieb zanieb mentioned this pull request Mar 21, 2025
Draft
@zanieb zanieb marked this pull request as draft March 21, 2025 19:40
@zanieb zanieb marked this pull request as ready for review March 21, 2025 19:59
@zanieb zanieb added the internal A refactor or improvement that is not user-facing label Mar 21, 2025
charliermarsh
charliermarsh approved these changes Mar 21, 2025
View reviewed changes
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to explicitly match on the allowed pre-release components (rather than accepting any [a-z]?

zanieb added a commit that referenced this pull request Mar 23, 2025
@zanieb
Add comments to the with_filtered_python_keys regex (#12379)
15bf83c 
I need to edit this thing and it's a nightmare as written.

See #12380
Base automatically changed from zb/regex-filtered to main March 23, 2025 02:57
@zanieb
Copy link
Member Author

zanieb commented Mar 23, 2025

Do you want to explicitly match on the allowed pre-release components (rather than accepting any [a-z]?

It's a fair question, it didn't seem worth the effort but it's not hard so, sure.

@zanieb zanieb enabled auto-merge (squash) March 23, 2025 03:02
@zanieb zanieb merged commit 8694578 into main Mar 23, 2025
76 checks passed
@zanieb zanieb deleted the zb/regex-pre branch March 23, 2025 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees
No one assigned
Labels
internal A refactor or improvement that is not user-facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zanieb @charliermarsh