Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore!: simple hygiene and renames #69

Merged
merged 10 commits into from
Jan 21, 2023
Merged

Chore!: simple hygiene and renames #69

merged 10 commits into from
Jan 21, 2023

Conversation

fjebaker
Copy link
Member

Working towards #68, remove the majority of those unused where {T} captures, and renamed a handful of functions to be more descriptive. This includes the names for the different metrics, which should now be consistent and also ommit needing to think about implementation details (the *AD or *FO tails).

Restructured some of the tests and reduced the resolution of the traces to hopefully speed the suite up a little. Added some tests for inference.

@codecov-commenter
Copy link

Codecov Report

Merging #69 (2222f41) into main (c381891) will increase coverage by 2.19%.
The diff coverage is 52.04%.

@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
+ Coverage   65.60%   67.80%   +2.19%     
==========================================
  Files          43       43              
  Lines        1439     1441       +2     
==========================================
+ Hits          944      977      +33     
+ Misses        495      464      -31     
Impacted Files Coverage Δ
src/GradusBase/metric-params.jl 25.00% <0.00%> (ø)
src/GradusBase/physical-quantities.jl 0.00% <0.00%> (ø)
src/accretion-geometry/bootstrap.jl 46.66% <0.00%> (ø)
src/corona-to-disc/corona-models.jl 83.33% <0.00%> (ø)
src/corona-to-disc/flux-calculations.jl 0.00% <ø> (ø)
src/corona-to-disc/sky-geometry.jl 89.65% <0.00%> (ø)
src/image-planes/planes.jl 82.50% <0.00%> (-11.79%) ⬇️
src/metrics/kerr-refractive-ad.jl 0.00% <0.00%> (ø)
src/orbits/orbit-interpolations.jl 0.00% <0.00%> (ø)
src/rendering/utility.jl 33.33% <0.00%> (ø)
... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fjebaker fjebaker marked this pull request as ready for review January 21, 2023 22:41
@fjebaker fjebaker merged commit b3b1656 into main Jan 21, 2023
@fjebaker fjebaker deleted the fergus/simple-hygiene branch January 21, 2023 22:41
fjebaker added a commit that referenced this pull request Aug 22, 2023
* test: special radii tests

* fix: hygiene and function names for special radii

* feat: reworked redshift const point function to specialise

* chore: remove where clauses and spacing

* chore: bump version

* chore: rename getgeodesicpoint to process_solution

* chore!: rename metrics to remove implementation details

* test: reorganise tests to run a bit faster

* style!: use KerrMetric to be consistent

* test: set tolerances for event horizon solver
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants