Chore!: simple hygiene and renames #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #69 +/- ##
==========================================
+ Coverage 65.60% 67.80% +2.19%
==========================================
Files 43 43
Lines 1439 1441 +2
==========================================
+ Hits 944 977 +33
+ Misses 495 464 -31
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fjebaker
added a commit
that referenced
this pull request
Aug 22, 2023
* test: special radii tests * fix: hygiene and function names for special radii * feat: reworked redshift const point function to specialise * chore: remove where clauses and spacing * chore: bump version * chore: rename getgeodesicpoint to process_solution * chore!: rename metrics to remove implementation details * test: reorganise tests to run a bit faster * style!: use KerrMetric to be consistent * test: set tolerances for event horizon solver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working towards #68, remove the majority of those unused
where {T}captures, and renamed a handful of functions to be more descriptive. This includes the names for the different metrics, which should now be consistent and also ommit needing to think about implementation details (the*ADor*FOtails).Restructured some of the tests and reduced the resolution of the traces to hopefully speed the suite up a little. Added some tests for inference.