Update legacy Rosenbrook #308
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This broke when removing non-log evidence values (PR290), which were previously used for logging only. Updated to work with log values only.
Since no mac wheels for latest version 0.1.9.
|
Tests are failing with the version of the code on main before this PR. It seems to be due to the toleranace for some flow tests, perhaps due to new library versions? While current updates fix Rosenbrock, we should check the other legacy examples work and, if not, update them. |
There was a problem hiding this comment.
I think the wheels work for the Python versions we support (which is why tests don't fail on Github) but I got this error when using Python 3.13. We don't have support for Python 3.13 anyway so we can also leave this without a pinned version and wait with Python 3.13 support until it's more mature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.