Dev radio #4
Dev radio #4
Conversation
There was a problem hiding this comment.
Main change is to revert changes to models/lightning/mmGAN.py (or explain why this is needed?) and to change naming from mMGAN -> GriGAN in plotting scripts, for clarity.
Other than that, I've highlighted some places we can tidy up scripts, where we have large amounts of old code, optional whether you want to fix this, but it'll only take a minute so I recommend.
|
Thanks @JessWhitney, I removed commented out old code and undid all the changes to the mmGAN files. Will pick up changing some of the READMEs next |
|
@JessWhitney Edited the main README now, let me know what you think about it. I'll add the documentation for reproducing the results later. |
There was a problem hiding this comment.
I went through the code, there are still some comments and use of mmGAN on the plotting scripts (the variable name, not the model imported) , but it's good enough for me.
If @JessWhitney approves, I'd be ok to merge this
No description provided.