Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix AF object handling with podman container engine #1759

Merged
merged 4 commits into from
Jan 29, 2025

Conversation

neel-astro
Copy link
Contributor

Description

Changes:

  • Pick the right container engine when running the AF objects related command, as of now we are hard-coded to docker, instead of picking the right container engine. This PR fixes that logic and adds error handling around it.

Describe the purpose of this pull request.

🎟 Issue(s)

Related #1724

🧪 Functional Testing

Added/updated applicable unit tests

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
neel-astro Neel Dalsania
@@ -28,7 +33,7 @@ func AirflowCommand(id, airflowCommand string) string {
}

stringOut := string(out)
return stringOut
return stringOut, nil
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed we're changing the function signature here and it got me wondering why this function didn't already return an error. Should we also return the error here on L32? - return errors.Wrapf(err, "error encountered executing airflow command") or something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, updated the PR

Verified

This commit was signed with the committer’s verified signature.
neel-astro Neel Dalsania

Verified

This commit was signed with the committer’s verified signature.
neel-astro Neel Dalsania

Verified

This commit was signed with the committer’s verified signature.
neel-astro Neel Dalsania
Copy link
Member

@schnie schnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @neel-astro!

@neel-astro neel-astro merged commit ac1b937 into main Jan 29, 2025
5 checks passed
@neel-astro neel-astro deleted the fix/af-object-podman branch January 29, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants