add catalog option to make_model_image #2044
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does something quite simple: it adds a
model_params
option tomake_model_image
. It still requires several things to be ready to be un-drafted:make_model_image
Before I do any of these though, a key question for @larrybradley : do you like this idea or do you think there's a better way to do this?
The context is that I was talking to a photutils user who wanted to add simulated stars to an image, and they naturally came to the
psf
machinery and expected to find a way to do it here. A couple of alternatives are available though: 1) just tell people to usedatasets.make_model_image
. I could modify this in that case to just be a documentation change that shows how to do this starting from a PSF. 2) add something to the PSF base classes instead of expecting them to build a photometry object even though they aren't necessarily planning to do photometry.