Skip to content

add catalog option to make_model_image #2044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eteq
Copy link
Member

@eteq eteq commented May 16, 2025

This PR does something quite simple: it adds a model_params option to make_model_image. It still requires several things to be ready to be un-drafted:

  • Add the option to the subclass' use of make_model_image
  • Tests
  • Asimple example in the docs?

Before I do any of these though, a key question for @larrybradley : do you like this idea or do you think there's a better way to do this?

The context is that I was talking to a photutils user who wanted to add simulated stars to an image, and they naturally came to the psf machinery and expected to find a way to do it here. A couple of alternatives are available though: 1) just tell people to use datasets.make_model_image. I could modify this in that case to just be a documentation change that shows how to do this starting from a PSF. 2) add something to the PSF base classes instead of expecting them to build a photometry object even though they aren't necessarily planning to do photometry.

@eteq eteq added the psf label May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant