MAINT: fixing new dependency as reshuffle CI jobs #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsipocz
added
the
Affects-dev
bsipocz
force-pushed
the
DEP_adding_optional_defusedxml
branch
from
273a6a6 to
ec7e852
Compare
bsipocz
changed the title
andamian
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#497 uses the new dependency and not just the tests, so it should be listed as an optional rather than a test dependency
This now also moves the linkcheck job to cron only. The docs build should be able to pick up any newly introduced API linking issues, and if a newly added URL is defunct, we will pick it up once it's merged, but won't fail PRs with unrelated failing URLs.
close #498