-
Notifications
You must be signed in to change notification settings - Fork 12
added app rating and review prompt #431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jayana-cpc
wants to merge
8
commits into
master
Choose a base branch
from
jayana/review-prompt
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a86a1e8
added app rating and review prompt
jayana-cpc 1a644ee
modified app rating prompting frequency
jayana-cpc 972fa39
Merge branch 'origin/master' into jayana/review-prompt
jayana-cpc 9791af8
implemented suggested edits for pr
jayana-cpc 8767137
Merge master into jayana/review-prompt
jayana-cpc 7b1dcd9
implemented suggested edits for pr (round 2)
jayana-cpc bf9a608
Merge branch 'master' of https://github.com/asuc-octo/berkeley-mobile…
jayana-cpc 82eca92
Addressed missed changes
jayana-cpc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| // | ||
| // ReviewPrompter.swift | ||
| // berkeley-mobile | ||
| // | ||
| // Created by Jayana Nanayakkara on 9/24/25. | ||
| // Copyright © 2025 ASUC OCTO. All rights reserved. | ||
| // | ||
|
|
||
| import Foundation | ||
| import StoreKit | ||
| import UIKit | ||
|
|
||
| enum ReviewPrompter { | ||
| private static let numLaunchesForReview: Int = 30 | ||
|
|
||
| private static func shouldPromptForReview() -> Bool { | ||
| let key = UserDefaultsKeys.numAppLaunchForAppStoreReview.rawValue | ||
| let launches = UserDefaults.standard.integer(forKey: key) | ||
| if launches == numLaunchesForReview { | ||
| UserDefaults.standard.set(0, forKey: key) | ||
| return true | ||
| } | ||
| return false | ||
| } | ||
|
|
||
| @MainActor | ||
| static func presentReviewIfNeeded() { | ||
| guard shouldPromptForReview() else { | ||
| return | ||
| } | ||
|
|
||
| if let scene = UIApplication.shared.connectedScenes | ||
| .first(where: { $0.activationState == .foregroundActive }) as? UIWindowScene { | ||
| AppStore.requestReview(in: scene) | ||
|
|
||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove newline |
||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,7 +10,7 @@ import UIKit | |
| import SwiftUI | ||
|
|
||
| class MainContainerViewController: UIViewController, MainDrawerViewDelegate { | ||
|
|
||
| // MainDrawerViewDelegate properties | ||
|
Comment on lines
-13
to
14
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's this change? |
||
| var drawerStack: [DrawerViewDelegate] = [] | ||
| var positions: [DrawerState?] = [] | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is
ReviewPrompteran enum?Shouldn't it be a class instead? Perhaps a singleton? https://developer.apple.com/documentation/swift/managing-a-shared-resource-using-a-singleton