#2024 - Fixed deprecation warning for DateTimeInterface::RFC7231 #2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderusse
reviewed
Jan 5, 2026
| if ('RFC822' === $format) { | ||
| $variable .= '->setTimezone(new \\DateTimeZone("GMT"))'; | ||
| $format = 'RFC7231'; | ||
| // Use RFC1123 instead of deprecated RFC7231 constant (PHP 8.5+) |
Member
There was a problem hiding this comment.
\DateTimeInterface::RFC1123 is identical to \DateTimeInterface::RFC822.
Which encodes GMT's timezone in +0000 and was an issue for MinIO (#1213)
We used RFC7231 instead of RFC822 in a similar way to the official PHP sdk.
If the constant is deprecated, then I suggest returning $variable . '->format(\'D, d M Y H:i:s \G\M\T\')';
Contributor
Author
There was a problem hiding this comment.
ok, I can do that
jderusse
reviewed
Jan 5, 2026
| final class DataType | ||
| { | ||
| public const FLOAT_32 = 'float32'; | ||
| public const UNKNOWN_TO_SDK = 'UNKNOWN_TO_SDK'; |
Member
|
could you please rebase your PR, to fix issue with |
Contributor
Author
|
@jderusse let me know if this fix works for you, thanks! |
Member
|
thank you @deluxetom |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DateTimeInterface::RFC7231#2024Fix PHP 8.5 deprecation warning for
DateTimeInterface::RFC7231constant by usingRFC1123instead.