fix: removed the focus: outline-none and added a visible focus. #1065
Conversation
ItshMoh
requested review from
magicmatatjahu,
derberg,
fmvilas and
asyncapi-bot-eve
as code owners
| @@ -33,7 +33,7 @@ export const CollapseButton: React.FunctionComponent<Props> = ({ | |||
| }) => ( | |||
| <button | |||
| {...rest} | |||
| className={`focus:outline-none ${rest.className}`} | |||
| className={`focus:ring-2 focus:ring-blue-500 focus:ring-offset-2 ${rest.className}`} | |||
There was a problem hiding this comment.
Here instead of using blue-500 color variant how's about using something which matches with the existing theme ?
|
|
This pull request has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation. There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
Removed the focus: outline-none and added a visible focus to the buttons.
Description
Related issue(s)
#958