Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: newsroom section is not ui friendly #3639

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
+380 −12
Open

fix: newsroom section is not ui friendly #3639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
af0e112
bug(Make newsroom ui)
jayraj175coder Feb 2, 2025
f3dfce8
bug(Make newsroomuui)
jayraj175coder Feb 2, 2025
17dbaeb
fix(ui of newsroom)
jayraj175coder Feb 2, 2025
322298e
fix: Comminutiy newsroom latest news section is not ui friendly.
jayraj175coder Feb 2, 2025
d055455
fix: Comminutiy newsroom latest news section is not ui friendly.
jayraj175coder Feb 2, 2025
3191aa3
fix: Comminutiy newsroom latest news section is not ui friendly.
jayraj175coder Feb 2, 2025
001f0ca
fix(newsroom): improve UI for better user experience
jayraj175coder Feb 2, 2025
2d8e3c5
Merge branch 'master' into newsSection
jayraj175coder Feb 3, 2025
518fd0c
fix: newsroom section ui
jayraj175coder Feb 3, 2025
dedd2a0
fix: newsroom section ui
jayraj175coder Feb 3, 2025
f566cea
fix: newsroom section ui
jayraj175coder Feb 3, 2025
c8b4739
fix: newsroom section ui
jayraj175coder Feb 3, 2025
1a2b731
fix: newsroom section ui
jayraj175coder Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/.prettierrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"tabWidth": 2,
"useTabs": false
}
1 change: 1 addition & 0 deletions .github/workflows/lighthouse-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ jobs:
configPath: ./.github/workflows/lighthouserc.json
uploadArtifacts: true
temporaryPublicStorage: true
artifactName: lighthouse-ci-results # Valid artifact name here
env:
PR_NUMBER: ${{ github.event.pull_request.number}}

Expand Down
278 changes: 276 additions & 2 deletions .github/workflows/scripts/mailchimp/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions .github/workflows/scripts/mailchimp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"license": "Apache 2.0",
"dependencies": {
"@actions/core": "1.6.0",
"@mailchimp/mailchimp_marketing": "3.0.74"
"@mailchimp/mailchimp_marketing": "3.0.74",
"schedule-email": "file:"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Local file dependency configuration issue detected.

The "schedule-email": "file:" entry in the .github/workflows/scripts/mailchimp/package.json file is incomplete because it lacks the local path to the dependency. Additionally, no directory named schedule-email exists in the repository. Please specify the correct local path to the package and ensure the package exists at the expected location.

  • Update the dependency entry to include a valid relative path (e.g., "schedule-email": "file:../schedule-email" if applicable).
  • Verify that the intended local package directory is present in the repository.
🔗 Analysis chain

Verify the local file dependency configuration.

The "schedule-email": "file:" dependency is missing a path to the local package.

Please ensure:

  1. The correct path to the local package is specified
  2. The package exists at the expected location

I'm not seeing the expected details for the local dependency configuration. To gather more information, please run the following scripts to inspect the contents of the Mailchimp workflow package file and check for any local package directories:

Once you’ve verified these outputs, please confirm that:

  • The "schedule-email" dependency in .github/workflows/scripts/mailchimp/package.json includes a valid path (instead of just "file:").
  • The referenced local package exists at the expected location.
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check if schedule-email package exists
fd -t f "package.json" | xargs grep -l "schedule-email"

Length of output: 53

Script:

#!/bin/bash
echo "=== Contents of .github/workflows/scripts/mailchimp/package.json ==="
grep -R '"schedule-email":' .github/workflows/scripts/mailchimp/package.json || echo "No 'schedule-email' dependency found in package.json."

echo ""
echo "=== Searching for directories named 'schedule-email' ==="
fd -t d "schedule-email" || echo "No directory named 'schedule-email' found in the repository."

Length of output: 420

}
}
}
6 changes: 3 additions & 3 deletions components/newsroom/Newsroom.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,10 @@ export default function Newsroom() {
</div>
</div>

<div className='w-full flex-row items-stretch justify-between md:flex md:h-120 lg:w-3/4'>
<div className='relative flex w-full flex-col overflow-y-auto md:w-1/2'>
<div className='flex h-auto w-full flex-col overflow-hidden rounded-xl bg-white shadow-lg sm:flex-row md:h-120 lg:w-3/4'>
<div className='scrollbar-hide relative flex w-full flex-col overflow-y-auto p-4 sm:p-6'>
<div className='min-h-0'>
<div className='md:t-0 md:b-0 md:l-0 md:r-0 size-full md:absolute'>
<div className='relative inset-0 flex items-center justify-center sm:absolute'>
<NewsroomArticle />
</div>
</div>
Expand Down
Loading
Loading