Skip to content

Add Kusto Cluster Diagnostic HealthCheck support #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 23, 2025
Merged

Conversation

perkops
Copy link
Member

@perkops perkops commented Jun 23, 2025

No description provided.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Kusto cluster diagnostic health check support by introducing a dedicated health check implementation, diagnostics model, interface, and extension method for ASP.NET Core integration. Key changes include:

  • Implementation of KustoClusterDiagnosticsHealthCheck with query execution and result mapping.
  • Creation of the KustoClusterDiagnostics model to encapsulate diagnostic data.
  • Updates to HealthCheckExtensions, sample projects, documentation, and project files to integrate and demonstrate the new functionality.

Reviewed Changes

Copilot reviewed 20 out of 34 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/Atc.Kusto/HealthChecks/KustoClusterDiagnosticsHealthCheck.cs Added health check implementation for Kusto cluster diagnostics.
src/Atc.Kusto/HealthChecks/KustoClusterDiagnostics.cs Introduced diagnostic data model for Kusto.
src/Atc.Kusto/HealthChecks/IKustoClusterDiagnosticsHealthCheck.cs Provided an interface for the Kusto health check.
src/Atc.Kusto/HealthChecks/HealthCheckExtensions.cs Added extension method for streamlined health check registration.
Various project and sample files Updated project references, dependency versions, and documentation.
Comments suppressed due to low confidence (1)

src/Atc.Kusto/HealthChecks/KustoClusterDiagnosticsHealthCheck.cs:19

  • The 'logger' field is used but not declared in this partial class file. Ensure that a corresponding field (e.g., 'private readonly ILogger logger;') is declared either in this file or in another partial definition.
        this.logger = logger;

Copy link

sonarqubecloud bot commented Jun 23, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
8.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copy link
Contributor

@lupusbytes lupusbytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@perkops perkops merged commit efd63df into main Jun 23, 2025
4 of 5 checks passed
@perkops perkops deleted the feature/healthcheck branch June 23, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants