Skip to content

Fix Tabs/Menu/Paginator wrapping when width is too small #1973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: develop
Choose a base branch
from
Draft

Fix Tabs/Menu/Paginator wrapping when width is too small #1973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8ac16a9
Fix non-breaking horizontal menus on mobiles
mkrecek234 Jan 21, 2023
1aa4348
Also required for Tabs to break properly for mobile devices
mkrecek234 Jan 21, 2023
53670b7
Revert "Fix non-breaking horizontal menus on mobiles"
mkrecek234 Jan 21, 2023
42e60f7
table in grid can be horizontally scrolled, make it unstackable
mvorisek Jan 23, 2023
c356477
make Multiline unstackable by default
mvorisek Jan 23, 2023
7a6bc9d
use wrapping /w buttons hack for Menu/Tabs
mvorisek Jan 23, 2023
3105ba5
same hack for Paginator
mvorisek Jan 23, 2023
ee9986e
impl. wrapping hack for menu using CSS
mvorisek Mar 31, 2024
14b4447
add link to FUI source
mvorisek Mar 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions js/src/vue-components/multiline/multiline.component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,11 @@ export default {
},
data: function () {
const tableDefault = {
basic: false,
compact: 'very',
basic: 'very',
unstackable: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when width is > stackable width (desktop), the format can be hard too read already, so this needs to be fixed properly in another PR

celled: false,
collapsing: false,
stackable: false,
inverted: false,
};

Expand Down
7 changes: 7 additions & 0 deletions public/css/agileui.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,13 @@ i.atk-panel-warning {
}
}

// add unofficial support for "wrapping" for Fomantic-UI Menu
// https://github.com/fomantic/Fomantic-UI/issues/2345
// https://github.com/fomantic/Fomantic-UI/blob/2.9.1/src/definitions/elements/button.less#L1901
.ui.menu.wrapping {
flex-wrap: wrap;
}

// Print

@media print {
Expand Down
2 changes: 1 addition & 1 deletion public/css/agileui.min.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion public/css/agileui.min.css.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions public/js/atk-vue-multiline.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion public/js/atk-vue-multiline.js.map
View file
Open in desktop

Large diffs are not rendered by default.

Loading