-
Notifications
You must be signed in to change notification settings - Fork 8
fix: workflow output path schedule mode #745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
drockparashar
wants to merge
8
commits into
atlanhq:main
Choose a base branch
from
drockparashar:fix/workflow-output-path-schedule-mode
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+48
−1
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e7faea8
fix: ensure consistent workflow output path for scheduled runs
drockparashar 989bdd4
Merge branch 'atlanhq:main' into fix/workflow-output-path-schedule-mode
drockparashar 0e76789
fix: ensure consistent workflow output path for scheduled runs
drockparashar d01931c
Merge branch 'fix/workflow-output-path-schedule-mode' of https://gith…
drockparashar c10ff41
test: add unit tests for build_output_path including empty workflow I…
drockparashar 00bc161
Merge branch 'main' into fix/workflow-output-path-schedule-mode
drockparashar 6f39e65
fix: use safe placeholder for empty workflow_id in build_output_path
drockparashar b257dcc
test: update build_output_path test to expect 'unknown-workflow' for …
drockparashar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's keep this variable localized as it's only used by a a single method as of now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I implemented that initially, but the copilot suggested me otherwise, what should i go with?