Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Atlassian] Issue of not using proxies inside rest client session #1488

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

flok
Copy link
Contributor

@flok flok commented Jan 13, 2025

Adds the provided proxies to the request session after creation.
Without this the proxies will not be used to download attachements for example.

Adds the provided proxies to the request session after creation.
@flok flok changed the title Add proxies to request session [Atlassian] Issue of not using proxies inside rest client session Jan 13, 2025
flok added 2 commits January 13, 2025 17:52
Delete trailing whitespace for codestyle
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 34.07%. Comparing base (9eb04fd) to head (fa5d81c).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
atlassian/rest_client.py 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1488      +/-   ##
==========================================
- Coverage   34.10%   34.07%   -0.04%     
==========================================
  Files          46       46              
  Lines        8753     8755       +2     
  Branches     1335     1232     -103     
==========================================
- Hits         2985     2983       -2     
- Misses       5646     5650       +4     
  Partials      122      122              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gonchik gonchik merged commit 85eea47 into atlassian-api:master Jan 17, 2025
6 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants