-
Notifications
You must be signed in to change notification settings - Fork 7
Integrate diagnostics into react_async_import_lift JS transformer
#944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 1f8358a The changes in this PR will be included in the next version bump. This PR includes changesets to release 112 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Rust Package Changeset Check✅ The |
📊 Type Coverage ReportCoverage Comparison
Files with Most Type Issues (Top 15)
This report was generated by the Type Coverage GitHub Action |
| )); | ||
| } | ||
|
|
||
| let module = module.apply(( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Splitting this was necessary so that the source map could be passed to the transformer
Motivation
Replicates the code tracing and build-cancellation on error in the native
react_async_import_lifttransformer that was present in the Babel original. This includes erroring and cancelling the build if configured to do so. I have tested and confirmed that this works as intended.Changes
react_async_import_liftJS transformerdiagnosticsinto the transformer instead of basic loggingChecklist
docs/folder