This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Fix for Atom Issue #8794 Remove 'null' text from front-facing messages #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -86,13 +86,22 @@ class GitHubFile | |||
| # Public | |||
| validationErrors: -> | |||
| unless @repo | |||
| return ["No repository found for path: #{@filePath}."] | |||
| if @filePath | |||
| return ["No repository found for path: #{@filePath}"] | |||
There was a problem hiding this comment.
Extra space between for and path
|
I'm pretty sure this doesn't fix atom/atom#8794 since this only deals with Atom notifications that relate to Open on Github, not browser notifications. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove 'null' from alert messages if the item that is being printed is 'null'. Fix for atom issue atom/atom#8794.
This is the original message when the element is 'null':
This is the message now: