Skip to content

Fix fail label logic with bs_create_bin #1731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release-0.6
Choose a base branch
from

Conversation

pguyot
Copy link
Collaborator

@pguyot pguyot commented Jun 26, 2025

Also simplify bs_create_bin
Add tests for bs_create_bin using Erlang assembly

These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).

SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later

@pguyot pguyot force-pushed the w26/fix-bs-create-bin branch 2 times, most recently from caf7f0c to 87de5d8 Compare June 26, 2025 20:30
Copy link
Collaborator

@bettio bettio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FreeBSD in a quite odd way.
Let's investigate it before merging this PR.

@pguyot
Copy link
Collaborator Author

pguyot commented Jun 27, 2025

FreeBSD in a quite odd way.

Let's investigate it before merging this PR.

The error seems to be:

sh: ./src/AtomV: not found

@UncleGrumpy
Copy link
Collaborator

UncleGrumpy commented Jun 27, 2025

I don’t know if this most recent FreeBSD failure is related to using ninja, but here logs reports “Packing archive test_estdlib_lib.avm” but line 125 of build-and-test-on-FreeBSD.yml tries to execute test_estdlib.avm.

@bettio
Copy link
Collaborator

bettio commented Jun 29, 2025

It looks like one of the yaml file is getting truncated:

   %% Running estdlib tests ...
  %%
  t is not an AVM or a BEAM file.

In case we find a fix of this, let's do that on a separated commit

@bettio
Copy link
Collaborator

bettio commented Jul 3, 2025

I think run script is getting truncated somehow at around 1003 characters.
I cannot really understand why it is happening just in this PR.

Anyway I opened an issue here:
vmactions/freebsd-vm#105

@pguyot
Copy link
Collaborator Author

pguyot commented Jul 3, 2025

I meant to remove part of this PR changes to see if this truncation still happens. Will try to do that tonight or this weekend.

Also simplify bs_create_bin
Add tests for bs_create_bin using Erlang assembly

Signed-off-by: Paul Guyot <[email protected]>
@pguyot pguyot force-pushed the w26/fix-bs-create-bin branch from dd93eed to 87d37bd Compare July 3, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants