Add file:get_cwd/0 #1806
Open
Add file:get_cwd/0 #1806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes are made under both the "Apache 2.0" and the "GNU Lesser General Public License 2.1 or later" license terms (dual license). SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later Added nif implementation for getcwd. Signed-off-by: Mateusz Front <[email protected]>
mat-hek
force-pushed
the
mf/prim-file-get-cwd
branch
from
4d432e3 to
36c9310
Compare
Fixes EXW-197 The problem was caused by allocating a tuple without initializing it. This meant the 2 words had GCed item (containing moved marker `0x2B`) or garbage. When calling `memory_ensure_free_with_roots`, a shallow copy of that tuple (it was the root) attempted to move that garbage and was failing. Signed-off-by: Mateusz Front <[email protected]>
mat-hek
force-pushed
the
mf/prim-file-get-cwd
branch
from
19e7b57 to
e2ae3ca
Compare
|
AFAIK, |
|
@pguyot indeed it's not, but we need it because it's called by the OTP internals, and not only by the file server |
Which module calls it? I searched OTP source code (for |
|
@pguyot well, now I can't find it either... changed to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later