Add file:native_name_encoding/0 #1807
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes are made under both the "Apache 2.0" and the "GNU Lesser General Public License 2.1 or later" license terms (dual license). SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later Implemented file:native_name_encoding/0 nif. Copied PRIMITIVE_UTF8_CHECK from https://github.com/erlang/otp/blob/OTP-26.0.2/erts/emulator/sys/common/erl_sys_common_misc.c. - I am open for better ideas. Signed-off-by: Mateusz Front <[email protected]>
pguyot
reviewed
Aug 20, 2025
|
|
||
| static bool env_equals(const char *env_var, const char *value) | ||
| { | ||
| const char *env_value = getenv(env_var); |
There was a problem hiding this comment.
POSIX says getenv is not thread safe. You need to hold global->env_spinlock.
| UNUSED(ctx) | ||
| UNUSED(argc) | ||
| UNUSED(argv) | ||
| if (env_equals("LC_ALL", "UTF-8") || env_equals("LC_CTYPE", "UTF-8") || env_equals("LANG", "UTF-8")) { |
There was a problem hiding this comment.
I am confused by this implementation. We could simply always return utf8, couldn't we? The most important part here is the documentation of the function.
mat-hek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later